Dan Hecht has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/4066/7/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 2119: // TODO: Replace with move() in Thrift 0.9.3. this comment only applies to line 2122, right? If so, it'd be better to move in there. Line 2122: broadcast_filter = &(const_cast<TBloomFilter&>(params.bloom_filter)); no need to break up the decl and assignment, even if it doesn't fit on a single line. also you don't need the parens around the const_cast -- To view, visit http://gerrit.cloudera.org:8080/4066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c52c8a1c2e79ef370c77bf264885fc859678d1b Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
