Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator ......................................................................
Patch Set 4: (1 comment) An Update: Ran it through ASAN and found an instance of use-after-free. Still trying to track down what exactly is going on. http://gerrit.cloudera.org:8080/#/c/4066/4/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS4, Line 474: filter_mem_tracker_ > all of the memory allocated for filters is specific to the query for which Sorry, my bad. Short lapse of confusion there. Yes it does belong to a particular query. The runtime state's mem tracker is destroyed when the RuntimeState object itself is destroyed. That is destroyed when the executor_ is destroyed, and the executor_ is destroyed when the Coordinator object is destroyed. So maybe this isn't a problem then. -- To view, visit http://gerrit.cloudera.org:8080/4066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c52c8a1c2e79ef370c77bf264885fc859678d1b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
