Henry Robinson has posted comments on this change. Change subject: IMPALA-4050: Support starting webserver specified by hostname ......................................................................
Patch Set 1: (3 comments) Thanks for the patch! Could you add a test to webserver-test.cc to confirm that this works with 'localhost'? http://gerrit.cloudera.org:8080/#/c/4185/1/be/src/util/webserver.cc File be/src/util/webserver.cc: Line 49: #include "util/network-util.h" put this on line 43, to keep the headers alphabetised. Line 236: stringstream listening_spec; Move this down to 239 to be as close as possible to the first use. PS1, Line 239: listening_spec << ip; : listening_spec << ":"; : listening_spec << http_address_.port; put this all on one line. -- To view, visit http://gerrit.cloudera.org:8080/4185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe7424a1c27f24560360219a5a6822b23dcbdce5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: hewenting <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
