hewenting has posted comments on this change. Change subject: IMPALA-4050: Support starting webserver specified by hostname ......................................................................
Patch Set 1: > (3 comments) > > Thanks for the patch! > > Could you add a test to webserver-test.cc to confirm that this > works with 'localhost'? OK。 Can I ask a question first? I'm not sure whether this is a bug? https://issues.cloudera.org/browse/IMPALA-4057 If we need not fix starting web server with interface 127.0.0.1. I'm not sure the test for 'localhost' for this patch will be ok. Thank you -- To view, visit http://gerrit.cloudera.org:8080/4185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe7424a1c27f24560360219a5a6822b23dcbdce5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: hewenting <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: hewenting <[email protected]> Gerrit-HasComments: No
