Youwei Wang has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. ......................................................................
Patch Set 2: -Code-Review > > Greetings, All. > > @Jim, considering the string reverse function is using the SIMDed > > Byteswap as internal implementation, do you thinkt it is okay to > > merge some test cases from this? > > https://gerrit.cloudera.org/#/c/4204/1/be/src/exprs/expr-test.cc > > Thank you :D > > What do you mean by "merge some test cases from"? Hi Jim. I have added some extra test cases for the function "reverse" in the file expr-test.cc: (line 1933-1946) https://gerrit.cloudera.org/#/c/4204/1/be/src/exprs/expr-test.cc If you don't mind, would you please take a look at that and then decide whether to add those test cases or not? Thank you :) -- To view, visit http://gerrit.cloudera.org:8080/4205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39b2b47bb717d5ac9727512a24fcf8a8a6a8dcc6 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: No
