Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4205/3/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 1931: { > Just for scoping so MAX_LEN, to_reverse and reversed don't conflict with an I think let's just make it a separate test, the long functions are fine when the tests are one-liners but when they have some setup, etc it gets hard to read (that's also all over the place in this file but I don't see a good reason to emulate it). -- To view, visit http://gerrit.cloudera.org:8080/4205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39b2b47bb717d5ac9727512a24fcf8a8a6a8dcc6 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
