Alex Behm has posted comments on this change. Change subject: IMPALA-4056: Fix toSql() of DistributeParam doesn't work as expected. ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4195/1//COMMIT_MSG Commit Message: Line 7: IMPALA-4056: Fix toSql() of DistributeParam doesn't work as expected. Fix toSql() of DistributeParam (remove the "doesn't work ..." part) Line 8: Add a brief description of what was broken. Looks like there were two issues: String literals were not quoted and the range partition split rows were not printed. http://gerrit.cloudera.org:8080/#/c/4195/1/fe/src/main/java/com/cloudera/impala/analysis/DistributeParam.java File fe/src/main/java/com/cloudera/impala/analysis/DistributeParam.java: Line 173: if (rangeElement instanceof StringLiteral) { you can use rangeElement.toSql() instead -- To view, visit http://gerrit.cloudera.org:8080/4195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Yuanhao Luo <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
