Alex Behm has posted comments on this change. Change subject: IMPALA-4056: Fix toSql() of DistributeParam ......................................................................
Patch Set 2: (4 comments) Thanks for the quick turnaround, almost done. http://gerrit.cloudera.org:8080/#/c/4195/2//COMMIT_MSG Commit Message: Line 9: This commit fix two issues in toSql() of DistributeParam: fixes Line 12: Besides, this commit fix a small issue in run-hive-server.sh fixes http://gerrit.cloudera.org:8080/#/c/4195/2/fe/src/main/java/com/cloudera/impala/analysis/DistributeParam.java File fe/src/main/java/com/cloudera/impala/analysis/DistributeParam.java: Line 173: rangeElementStrings.add((rangeElement.toSqlImpl())); remove extra parens, also use toSql() instead of toSqlImpl() http://gerrit.cloudera.org:8080/#/c/4195/2/testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test File testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test: Line 41: -- Test error handling for split rows with too many components Remove this end-to-end test and make an analyzer test instead. See AnalyzeDDLTest.java TestCreateKuduTable() -- To view, visit http://gerrit.cloudera.org:8080/4195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Yuanhao Luo <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Yuanhao Luo <[email protected]> Gerrit-HasComments: Yes
