Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: benchmark byteswap on misaligned memory ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4290/1/be/src/benchmarks/bswap-benchmark.cc File be/src/benchmarks/bswap-benchmark.cc: PS1, Line 120: perfectly aligned of SIMD > I'm not sure these are guaranteed to be aligned. I assume the array that ve Good point. Used posix_memalign to 64-bytes (so that it's aligned to cache lines too. PS1, Line 122: vector > const, here and in the range-based for loop Done -- To view, visit http://gerrit.cloudera.org:8080/4290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9dfcca718b2456488d0fb4407d3817c796bfad0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
