Jim Apple has posted comments on this change. Change subject: IMPALA-4058: benchmark byteswap on misaligned memory ......................................................................
Patch Set 3: Code-Review+2 (2 comments) Just some nits; feel free to skip http://gerrit.cloudera.org:8080/#/c/4290/3/be/src/benchmarks/bswap-benchmark.cc File be/src/benchmarks/bswap-benchmark.cc: Line 139: uint8_t* outbuffer = You could sprinkle some consts in here, too. Line 158: free(inbuffer); This might be RAIIable with unique_ptr custom deleters + auto. -- To view, visit http://gerrit.cloudera.org:8080/4290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9dfcca718b2456488d0fb4407d3817c796bfad0 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
