Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator ......................................................................
Patch Set 14: (13 comments) All these comments addressed in: https://gerrit.cloudera.org/#/c/4306/ http://gerrit.cloudera.org:8080/#/c/4066/11/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 380: for (; entry != _TExecNodePhase_VALUES_TO_NAMES.end(); ++entry) { > the QueryState tear-down will not happen until the refcount is 0, and the r Done http://gerrit.cloudera.org:8080/#/c/4066/12/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS12, Line 272: boost > remove boost:: Done PS12, Line 275: std > remove std:: Done PS12, Line 296: std > remove std:: Done PS12, Line 299: boost > remove boost:: Done PS12, Line 313: local > local? Removed 'local'. Line 324: > remove blank line Done PS12, Line 369: // This may be NULL while executing UDFs. : if (filter_mem_tracker_.get() != nullptr) { : filter_mem_tracker_->UnregisterFromParent(); : } > Why not do this in TearDown()? Done Line 2074: DCHECK(state->disabled() || state->pending_count() == 0); > This just DCHECKS the previous line (except covering the case where pending Probably not. Removed it. PS12, Line 2091: filter_mem_tracker_->Release(aggregated_filter->directory.size()); > nit: shouldn't you release *after* the swap()? Won't make any difference in We could, but I just thought it would be more readable this way because if we do it after, aggregated_filter->directory.size() will be 0. And we will have to release it from rpc_params instead which could confuse readers. PS12, Line 2100: Disable > Doesn't this mean that every filter eventually gets a 'true' in its Disable Yes, fixed this in the follow up patch. PS12, Line 2133: Disable(coord->filter_mem_tracker_.get()); > not clear - is this branch only taken if the filter is partitioned only? Ot Yes, fixed it in the follow up patch. http://gerrit.cloudera.org:8080/#/c/4066/13/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS13, Line 306: Only set for partitioned joins > is this true? i think the latest revisions made this a false statement, no? Yes, but now the follow-up fix is back to this case. So leaving it as it is. -- To view, visit http://gerrit.cloudera.org:8080/4066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c52c8a1c2e79ef370c77bf264885fc859678d1b Gerrit-PatchSet: 14 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
