Dan Hecht has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator ......................................................................
Patch Set 13: (1 comment) > This is a bug, but not worth holding up the build for. This is an > edge case - coordinator doesn't have enough memory for the first > filter, but does for the second. I asked Sailesh to file a > follow-on JIRA. Sure, sounds good. Even sounds like more of a design choice rather than a bug. But I'm good either way. http://gerrit.cloudera.org:8080/#/c/4066/13/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS13, Line 306: Only set for partitioned joins is this true? i think the latest revisions made this a false statement, no? -- To view, visit http://gerrit.cloudera.org:8080/4066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c52c8a1c2e79ef370c77bf264885fc859678d1b Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
