Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567: move ExecOption profile helpers to RuntimeProfile ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4188/4/be/src/util/runtime-profile.h File be/src/util/runtime-profile.h: Line 212: /// 'codegen_enabled' is true (e.g. if codegen is disabled by a query option, > not? Done PS4, Line 214: Msg > Oh, I didn't mean you had to rename this one, since this one does take a St Yeah it made sense to me since it was just using the message from the status -- To view, visit http://gerrit.cloudera.org:8080/4188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21c1dda8f8a1d92172bf59fbc1070a6834e61913 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
