Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3567: move ExecOption profile helpers to RuntimeProfile ......................................................................
IMPALA-3567: move ExecOption profile helpers to RuntimeProfile This is groundwork for IMPALA-3567, which will move some logic that previously resided in ExecNodes into DataSinks. We want to report ExecOption strings consistently in both ExecNodes and DataSinks, so that logic needs to move to a shared place (e.g. the RuntimeProfile itself). I ran the patch through clang-format, which changed line wrapping and indentation of a few surrounding lines. Change-Id: I21c1dda8f8a1d92172bf59fbc1070a6834e61913 Reviewed-on: http://gerrit.cloudera.org:8080/4188 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Internal Jenkins --- M be/src/exec/aggregation-node.cc M be/src/exec/blocking-join-node.cc M be/src/exec/exec-node.cc M be/src/exec/exec-node.h M be/src/exec/hash-join-node.cc M be/src/exec/hdfs-scan-node.cc M be/src/exec/partitioned-aggregation-node.cc M be/src/exec/partitioned-hash-join-node.cc M be/src/exec/sort-node.cc M be/src/exec/topn-node.cc M be/src/util/runtime-profile.cc M be/src/util/runtime-profile.h 12 files changed, 114 insertions(+), 98 deletions(-) Approvals: Internal Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/4188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21c1dda8f8a1d92172bf59fbc1070a6834e61913 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
