Lars Volker has posted comments on this change.

Change subject: Allow buildall.sh to work from snapshots (not just git 
checkouts)
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4336/1//COMMIT_MSG
Commit Message:

Line 7: Allow buildall.sh to work from snapshots (not just git checkouts)
Can you create an upstream issue to track this?


http://gerrit.cloudera.org:8080/#/c/4336/1/bin/clean.sh
File bin/clean.sh:

Line 55: if git rev-parse &>dev/null; then
You could rewrite these as such

git rev-parse &>dev/null && git clean -Xdfq


-- 
To view, visit http://gerrit.cloudera.org:8080/4336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12dd9035298151557491009680d66d25c8f58c1d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-HasComments: Yes

Reply via email to