Michael Brown has posted comments on this change. Change subject: IMPALA-4096: Allow clean.sh to work from snapshots ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4336/2/bin/clean.sh File bin/clean.sh: PS2, Line 55: git rev-parse &>dev/null Here and elsewhere, you're missing the leading / for /dev/null unless this is some fancy bashism I don't know about. Can you also make sure that the &> operator is supported on CentOS 5? &>> is definitely not (see https://gerrit.cloudera.org/#/c/3531/ , for example) -- To view, visit http://gerrit.cloudera.org:8080/4336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12dd9035298151557491009680d66d25c8f58c1d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
