Amos Bird has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. ......................................................................
Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/3942/7/fe/src/main/java/com/cloudera/impala/analysis/PartitionSet.java File fe/src/main/java/com/cloudera/impala/analysis/PartitionSet.java: Line 86: checkAddIfExists(analyzer, table_, transformedConjuncts); > addIfExists() Done Line 136: if (partitionShouldExist_ != null) { > Not sure what I was thinking the first time around, but I don't think this Done http://gerrit.cloudera.org:8080/#/c/3942/7/fe/src/main/java/com/cloudera/impala/analysis/PartitionSpecBase.java File fe/src/main/java/com/cloudera/impala/analysis/PartitionSpecBase.java: Line 92: // Make sure the target table is partitioned. > remove, already checked above Done http://gerrit.cloudera.org:8080/#/c/3942/7/fe/src/test/java/com/cloudera/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/com/cloudera/impala/analysis/AnalyzeDDLTest.java: Line 153: AnalysisError("alter table functional.alltypes drop " + > move these 2 tests below L179 Done Line 189: "A partition spec may not contain constant predicates."); > should also print the offending expr It's printed. http://gerrit.cloudera.org:8080/#/c/3942/7/testdata/workloads/functional-query/queries/QueryTest/partition-ddl-predicates.test File testdata/workloads/functional-query/queries/QueryTest/partition-ddl-predicates.test: Line 12: alter table p1 add partition (j=2,k=NULL); > more NULLs, we should have Done Line 33: regex:.+,'4B','j=1/k=a' > safer to use regex for the size (second column) as well Done -- To view, visit http://gerrit.cloudera.org:8080/3942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c9162fcf9d227b8daf4c2e761d57bab4e26408f Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Amos Bird <[email protected]> Gerrit-HasComments: Yes
