Alex Behm has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. ......................................................................
Patch Set 8: Code-Review+2 (1 comment) Amos, thank you for your continued dedication! I really appreciate your fast turnaround time. This is a useful new feature and a sizeable patch. We are very grateful for your significant contribution, and look forward to more :) After you make the last change, I'll run a private build and will get your patch merged. http://gerrit.cloudera.org:8080/#/c/3942/8/testdata/workloads/functional-query/queries/QueryTest/partition-ddl-predicates.test File testdata/workloads/functional-query/queries/QueryTest/partition-ddl-predicates.test: Line 140: alter table p1 drop partition (j=2, k=NULL) Add one more test: alter table p1 drop partition (j IS NULL AND k IS NULL); -- To view, visit http://gerrit.cloudera.org:8080/3942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c9162fcf9d227b8daf4c2e761d57bab4e26408f Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Amos Bird <[email protected]> Gerrit-HasComments: Yes
