Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4097: Crash in kudu-scan-node-test ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4337/1/be/src/exec/kudu-scan-node-test.cc File be/src/exec/kudu-scan-node-test.cc: PS1, Line 320: 1) the row batch containing : // the single row, 2) an empty row batch (since there are scanners created for both : // tablets), and 3) a final call which returns eos. > nit: this might be more readable if you have one point per line I'll change this but not worth uploading a new diff for this alone. I'll upload the change with the next set of comments. -- To view, visit http://gerrit.cloudera.org:8080/4337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e30964232ed137fce7a99bf7e9557293b5905c8 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
