Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4097: Crash in kudu-scan-node-test ......................................................................
IMPALA-4097: Crash in kudu-scan-node-test The kudu-scan-node-test was calling GetNext() with a NULL row batch, which isn't valid. This wasn't failing until a recent code change, and only occasionally due to the timing of scanner threads producing row batches. One batch is empty and the other has 1 row. This test worked when the empty row batch was added to the batch queue first (which usually happened), but the test code couldn't handle the other ordering properly. This fixes the test to be more careful about what is being exercised. Change-Id: I0e30964232ed137fce7a99bf7e9557293b5905c8 Reviewed-on: http://gerrit.cloudera.org:8080/4337 Reviewed-by: Dan Hecht <[email protected]> Tested-by: Internal Jenkins --- M be/src/exec/kudu-scan-node-test.cc M be/src/exec/kudu-scan-node.cc 2 files changed, 23 insertions(+), 9 deletions(-) Approvals: Internal Jenkins: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/4337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e30964232ed137fce7a99bf7e9557293b5905c8 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
