Michael Brown has posted comments on this change. Change subject: IMPALA-4100, IMPALA-4112: RQG-on-Hive: Replace EXTRACT UDF and IS [NOT] DISTINCT FROM in HiveSqlWriter ......................................................................
Patch Set 1: (2 comments) Thanks for the patch! This is easy to review since the changes are small and isolated to HiveSqlWriter. http://gerrit.cloudera.org:8080/#/c/4357/1//COMMIT_MSG Commit Message: Line 7: IMPALA-4100, IMPALA-4112: RQG-on-Hive: Replace EXTRACT UDF and IS [NOT] DISTINCT FROM in HiveSqlWriter Please keep the commit message to < 90 characters at most. For this line, you can convey the same info with: IMPALA-4100,4112: qgen: replace EXTRACT UDF and IS [NOT] DISTINCT FROM in HiveSqlWriter http://gerrit.cloudera.org:8080/#/c/4357/1/tests/comparison/model_translator.py File tests/comparison/model_translator.py: PS1, Line 462: self.operator_funcs['IsNotDistinctFrom'] = '({0}) <=> ({1})' : self.operator_funcs['IsNotDistinctFromOp'] = '({0}) <=> ({1})' : self.operator_funcs['IsDistinctFrom'] = 'NOT(({0}) <=> ({1}))' What do you think about: self.operator_funcs.update({ 'IsNotDistinctFrom': '({0}) <=> ({1})', # etc. }) -- To view, visit http://gerrit.cloudera.org:8080/4357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3922ca61af59ecd2899c911b1a03e11ab5c26e11 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: [email protected] Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
