[email protected] has posted comments on this change. Change subject: IMPALA-4100,4112: Qgen: Replace EXTRACT UDF + IS [NOT] DISTINCT FROM in HiveSqlWriter ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4357/1//COMMIT_MSG Commit Message: Line 7: IMPALA-4100,4112: Qgen: Replace EXTRACT UDF + IS [NOT] DISTINCT FROM in HiveSqlWriter > Please keep the commit message to < 90 characters at most. Will do, fixed http://gerrit.cloudera.org:8080/#/c/4357/1/tests/comparison/model_translator.py File tests/comparison/model_translator.py: PS1, Line 462: self.operator_funcs.update({ : 'IsNotDistinctFrom': '({0}) <=> ({1})', : 'IsNotDistinctFromOp': '({0}) <=> ({1})', > What do you think about: Sounds good to me, updated. -- To view, visit http://gerrit.cloudera.org:8080/4357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3922ca61af59ecd2899c911b1a03e11ab5c26e11 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: [email protected] Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes
