Michael Brown has posted comments on this change.

Change subject: Versioning of build artifacts
......................................................................


Patch Set 2:

(2 comments)

Nice idea.

http://gerrit.cloudera.org:8080/#/c/4742/2/buildall.sh
File buildall.sh:

PS2, Line 69: (
Out of curiosity, any reason you put LLVM building in a subshell, but nothing 
else?


http://gerrit.cloudera.org:8080/#/c/4742/2/functions.sh
File functions.sh:

PS2, Line 428:   echo "${UNIQUE_ID}-${GIT_HASH}"
Nit or maybe my preference only: put git hash first?


-- 
To view, visit http://gerrit.cloudera.org:8080/4742
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb8774a7bd4bcae0c135684078f5ce89a28f6bc2
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to