Tim Armstrong has posted comments on this change. Change subject: Versioning of build artifacts ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4742/2/buildall.sh File buildall.sh: PS2, Line 69: ( > Out of curiosity, any reason you put LLVM building in a subshell, but nothi To avoid leaking the PYTHON_VERSION variable to other steps. http://gerrit.cloudera.org:8080/#/c/4742/2/functions.sh File functions.sh: PS2, Line 428: echo "${UNIQUE_ID}-${GIT_HASH}" > Nit or maybe my preference only: put git hash first? I think it ends up being more readable in the s3 console if the build number comes first, since they'll be in chronological order -- To view, visit http://gerrit.cloudera.org:8080/4742 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8774a7bd4bcae0c135684078f5ce89a28f6bc2 Gerrit-PatchSet: 2 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
