Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4477: Bump Kudu version to latest commit on master ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5053/1/buildall.sh File buildall.sh: PS1, Line 242: 88b023 > Instead of hardcoding the git hash value would it make sense to read some e yeah I don't love this either, but if we start building against this version I think we do want it to be clearly specified. If this comes from an env variable, we have to keep that value somewhere too, since we're coding against this version now, and since it has to live somewhere I think it might as well be checked in so it's safe. I dunno, I'm open to other options but not sure I see something better. Lemme know if you wanna chat about it. -- To view, visit http://gerrit.cloudera.org:8080/5053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4771dec1e25a5483adfeb84349b8ff06d9ddccd Gerrit-PatchSet: 1 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
