[
https://issues.apache.org/jira/browse/INLONG-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341241#comment-17341241
]
Guocheng Zhang commented on INLONG-605:
---------------------------------------
Hi Roc Marshal, thanks for your contributions first!
Can you choose an independent module according to your idea, create a sub-issue
and submit a pr for improvement?
So that the modification content will be clearer. I think your proposal should
be OK, the implementation codes are not concise enough.
Sorry for my slow response, I've been on vacation, and there are some problems
with the internet visit
Thanks
> Refactor the INLONG configuration framework
> -------------------------------------------
>
> Key: INLONG-605
> URL: https://issues.apache.org/jira/browse/INLONG-605
> Project: Apache InLong
> Issue Type: Improvement
> Components: Broker, Client, Master, Server
> Reporter: Roc Marshal
> Priority: Major
> Labels: patch
>
> # Reconstruct it according to the [Flink configuration
> module|https://github.com/apache/flink/tree/master/flink-core/src/main/java/org/apache/flink/configuration]
> format to make improvements for codes quality, such as these core classes
>
> [ConfigConstants.java|https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java]
>
> [ConfigOption.java|https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java]
>
> [ConfigOptions.java|https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigOptions.java]
>
> [Configuration.java|https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/Configuration.java]
> etc.
> # Classes that might need to be refactored:
>
> [BrokerConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-server/src/main/java/org/apache/tubemq/server/broker/BrokerConfig.java]
>
>
> [AbstractFileConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-server/src/main/java/org/apache/tubemq/server/common/fileconfig/AbstractFileConfig.java]
>
> [TLSConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-core/src/main/java/org/apache/tubemq/corebase/config/TLSConfig.java]
>
> [TubeClientConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-client/src/main/java/org/apache/tubemq/client/config/TubeClientConfig.java]
>
> [ConsumerConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-client/src/main/java/org/apache/tubemq/client/config/ConsumerConfig.java]
>
> [TubeClientConfigUtils.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-client/src/main/java/org/apache/tubemq/client/config/TubeClientConfigUtils.java]
>
> [MasterReplicationConfig.java|http://https//github.com/apache/incubator-inlong/blob/master/tubemq-server/src/main/java/org/apache/tubemq/server/common/fileconfig/MasterReplicationConfig.java]
>
> [RpcConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-core/src/main/java/org/apache/tubemq/corerpc/RpcConfig.java]
>
> [RpcConstants.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-core/src/main/java/org/apache/tubemq/corerpc/RpcConstants.java]
> # Group these configuration items based on their component
> roles.Master,Broker,Client..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
