[
https://issues.apache.org/jira/browse/INLONG-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348040#comment-17348040
] Roc Marshal commented on INLONG-605: ------------------------------------ [~gosonzhang] My initial idea is to divide it into two parts. part 1: Introduce ConfigConstants.java , then extract the keys and default values of all configuration items into the ConfigConstants.java. And I plan to use the ConfigConstants keys and default values references to replace related string constant value. This part of the work will be regarded as a transitional stage of reconstruction. part2: Introduce ConfigOption like [ConfigOption.java|https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java] ConfigOptions like [ConfigOptions.java|https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigOptions.java] Configuration like [Configuration.java|https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/Configuration.java] to describe configuration items better. And split the reconstruction work into three sections INLONG-608, INLONG-609, INLONG-610. What do you think about this ? > Refactor the INLONG configuration framework > ------------------------------------------- > > Key: INLONG-605 > URL: https://issues.apache.org/jira/browse/INLONG-605 > Project: Apache InLong > Issue Type: Improvement > Components: Broker, Client, Master, Server > Reporter: Roc Marshal > Assignee: Roc Marshal > Priority: Major > Labels: patch > > # Reconstruct it according to the [Flink configuration > module|https://github.com/apache/flink/tree/master/flink-core/src/main/java/org/apache/flink/configuration] > format to make improvements for codes quality, such as these core classes > > [ConfigConstants.java|https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java] > > [ConfigOption.java|https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java] > > [ConfigOptions.java|https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigOptions.java] > > [Configuration.java|https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/Configuration.java] > etc. > # Classes that might need to be refactored: > > [BrokerConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-server/src/main/java/org/apache/tubemq/server/broker/BrokerConfig.java] > > > [AbstractFileConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-server/src/main/java/org/apache/tubemq/server/common/fileconfig/AbstractFileConfig.java] > > [TLSConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-core/src/main/java/org/apache/tubemq/corebase/config/TLSConfig.java] > > [TubeClientConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-client/src/main/java/org/apache/tubemq/client/config/TubeClientConfig.java] > > [ConsumerConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-client/src/main/java/org/apache/tubemq/client/config/ConsumerConfig.java] > > [TubeClientConfigUtils.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-client/src/main/java/org/apache/tubemq/client/config/TubeClientConfigUtils.java] > > [MasterReplicationConfig.java|http://https//github.com/apache/incubator-inlong/blob/master/tubemq-server/src/main/java/org/apache/tubemq/server/common/fileconfig/MasterReplicationConfig.java] > > [RpcConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-core/src/main/java/org/apache/tubemq/corerpc/RpcConfig.java] > > [RpcConstants.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-core/src/main/java/org/apache/tubemq/corerpc/RpcConstants.java] > # Group these configuration items based on their component > roles.Master,Broker,Client.. -- This message was sent by Atlassian Jira (v8.3.4#803005)
