jixuan1989 commented on a change in pull request #5: Force in thread
periodically
URL: https://github.com/apache/incubator-iotdb/pull/5#discussion_r249267978
##########
File path:
iotdb/src/main/java/org/apache/iotdb/db/writelog/manager/MultiFileLogNodeManager.java
##########
@@ -123,15 +152,17 @@ public void recover() throws RecoverException {
@Override
public void close() {
- if (syncThread == null || !syncThread.isAlive()) {
+ if (syncThread == null || !syncThread.isAlive() || forceThread == null ||
!forceThread
+ .isAlive()) {
Review comment:
You can't return here. Suppose syncThread is alive but forceThread is dead
because of some exceptions..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
