jixuan1989 commented on a change in pull request #5: Force in thread
periodically
URL: https://github.com/apache/incubator-iotdb/pull/5#discussion_r249283662
##########
File path:
iotdb/src/main/java/org/apache/iotdb/db/writelog/manager/MultiFileLogNodeManager.java
##########
@@ -123,15 +152,17 @@ public void recover() throws RecoverException {
@Override
public void close() {
- if (syncThread == null || !syncThread.isAlive()) {
+ if (syncThread == null || !syncThread.isAlive() || forceThread == null ||
!forceThread
+ .isAlive()) {
Review comment:
how about close one by one? No need to use `if-else`.
e.g.,
```java
if(syncThread is active) then close it;
if(forceThread is active) then close it;
```
By the way, because this issue wants to solve the performance problem. can
you attach a comparison result? (attach the comparison result on JIRA is better
because the search engine can index it)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
