kr11 commented on a change in pull request #25: Fix sonar
URL: https://github.com/apache/incubator-iotdb/pull/25#discussion_r250517122
##########
File path: iotdb-cli/src/main/java/org/apache/iotdb/cli/client/WinClient.java
##########
@@ -41,7 +41,6 @@
*/
public static void main(String[] args) throws ClassNotFoundException,
SQLException {
Review comment:
In my opinion, we don't recommend reconstruct Client/WinClient in this PR:
1. This PR focuses on addressing the sonar prompts to improve the code
quality in code line level, but not package/class level.
2. It's right that `Client` is similar to and shorter than `WinClient`,
nevertheless, this reconstruction might be more difficult than the other
changes in the same PR. I recommend to fix it in next PR. @jt2594838 @MyXOF
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
