kr11 commented on a change in pull request #25: Fix sonar
URL: https://github.com/apache/incubator-iotdb/pull/25#discussion_r250519595
##########
File path:
tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/ChunkBuffer.java
##########
@@ -99,21 +99,18 @@ public int writePageHeaderAndDataIntoBuff(ByteBuffer data,
int valueCount,
}
this.maxTimestamp = maxTimestamp;
int uncompressedSize = data.remaining();
- int maxSize = compressor.getMaxBytesForCompression(uncompressedSize);
+ compressor.getMaxBytesForCompression(uncompressedSize);
Review comment:
In the primary code, the result `maxSize` is unused. I guess this line is to
invoke `getMaxBytesForCompression` to perform something(e.g. skipping an
unconcerned byte), but not interested in the result.
Maybe @jixuan1989 could explain it more?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
