Hi all,

while looking into the binary distribution issue I had to look into the other 
parts.
Unfortunately I do have to report quite some bad practices being used.

In the “server” aka “iotdb-server” module:
Here you redirect the output of different maven standard plugins to build a 
“distribution” outside the target directory.
I would strongly suggest not to do that and to use the assembly plugin in that 
module to build a server-distribution.
The way you are doing it, you need to add exceptions and includes and excludes 
all over the place because you are moving things away from the default 
locations.

In the “client” aka “iotdb-client” module:
Same applies as for the “server”

“tsfile”:
Here you have a non-pom type module and an embedded example module. That 
doesn’t work in Maven.
How about moving this example to the examples section?

“Hadoop”:
This is not included in the build … why?

“docs”:
Here I can see docs, but they are not processed to HTML versions via the site 
plugin.

Dependency versions:

  *   There seem to be some dependencies in different versions, these should be 
streamlined via dependencyManagement section:
     *   commons-lang3
     *   jsline
     *   slf4j-api

If you don’t do that, you will have multiple versions of the same libraries in 
your classpath which can/will cause extremely difficult to debug problems.

  *   The old distribution and probably also the server and or cli bundles seem 
to contain test dependencies

Chris


Reply via email to