Hi, I checked rel/0.8 branch:
> “Hadoop”: > This is not included in the build … why? I checked this module and find that the module still use classes in TsFile v0.7.0... Upgrading it is not a very easy work.. So, how about keep commenting the module in v0.8.0.. We can finish it in the next release. > There seem to be some dependencies in different versions, these should be streamlined via dependencyManagement section: > * commons-lang3 > * jsline > * slf4j-api I just find commons-lang3 has 2 versions. Only the "client" module depends on jline (so why it has different versions..)... As for slf4j-api, I search the keyword in all pom files and find that we do not declare it explicitly. Do we need to declare it explicitly? > In the “server” aka “iotdb-server” module: > In the “client” aka “iotdb-client” module: Agree with using standard plugin... (By the way, now when I run `mvn package -Papache-release`, no *-bin.zip file is generated in the target folder...) Best, ----------------------------------- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Christofer Dutz <[email protected]> 于2019年8月2日周五 下午3:46写道： > Hi all, > > while looking into the binary distribution issue I had to look into the > other parts. > Unfortunately I do have to report quite some bad practices being used. > > In the “server” aka “iotdb-server” module: > Here you redirect the output of different maven standard plugins to build > a “distribution” outside the target directory. > I would strongly suggest not to do that and to use the assembly plugin in > that module to build a server-distribution. > The way you are doing it, you need to add exceptions and includes and > excludes all over the place because you are moving things away from the > default locations. > > In the “client” aka “iotdb-client” module: > Same applies as for the “server” > > “tsfile”: > Here you have a non-pom type module and an embedded example module. That > doesn’t work in Maven. > How about moving this example to the examples section? > > “Hadoop”: > This is not included in the build … why? > > “docs”: > Here I can see docs, but they are not processed to HTML versions via the > site plugin. > > Dependency versions: > > * There seem to be some dependencies in different versions, these > should be streamlined via dependencyManagement section: > * commons-lang3 > * jsline > * slf4j-api > > If you don’t do that, you will have multiple versions of the same > libraries in your classpath which can/will cause extremely difficult to > debug problems. > > * The old distribution and probably also the server and or cli bundles > seem to contain test dependencies > > Chris > > >
