This time it looks a lot better ... good job.
I wish more podlings would address issues found like you all are.
+1 (binding) Chris
What I checked:
- Source Release:
- Signatures check and reference an apache email
- Hashes match
- Unpacks correctly to the expected structure
- LICENSE, NOTICE, README, RELEASE_NOTES look good
- Builds successfully using description in README.md
- Builds successfully using all modules and all tests (mvn clean verify)
- All binaries detected by RAT are pictures (Grafana module)
- Binary Distribution:
- Signatures check and reference an apache email
- Hashes match
- Unpacks correctly to the expected structure
- LICENSE, NOTICE, README, RELEASE_NOTES look good (However does the
README.md refer to the source-distribution so for someone using the binary
distribution it's pretty useless. Perhaps a README-binary.md would be a good
idea)
- Was able to start the server and the client and all looked good.
Little things I noticed:
- The rat exclusions in pom.xml list:
<exclude>iotdb/data/**</exclude>
<exclude>iotdb/logs/**</exclude>
Both should be obsolete as you renamed the directory.
- The comment below, regarding the perTestInputData file ... tests really
shouldn't be writing stuff in the "src" section of the build. This is what
belongs in the "target" section.
- spark-tsfile seems to have an impressive collection of dependencies with
known vulnerabilities (Most others have some too ... It would be good to
resolve these as they produce warnings on the comandline)
- Still found SNAPSHOT in the Hadoop module, but this is commented out (You
should fix the Hadoop problems soon, this sort of thing is less than ideal) ...
and be sure to manually update the version in the repository or you'll run into
nasty maven problems.
- The README.md in the binary distribution doesn't seem to match the binary
distribution.
Good job all.
Chris
Am 02.08.19, 15:00 schrieb "Julian Feinauer" <[email protected]>:
Hi all,
thanks to all reviewers of the RC1 and to everybody who helped to fix all
issues we are able to vote again for the second release candidate.
Important: All PMCs please note that you have to CHECK the release
artifacts [2] (see below) before being allowed to vote “+1”, see [3,4].
Apache IoTDB (Incubating) 0.8.0 has been staged under [2] and it’s time to
vote
on accepting it for release. All Maven artifacts are available under [1].
If approved we will seek final release approval from the IPMC.
Voting will be open for 72hr.
A minimum of 3 binding +1 votes and more binding +1 than binding -1
are required to pass.
Release tag: release/0.8.0
Hash for the release tag: 7b242b02bf4f8ef0df298a49ea9a977b50c526d5
Per [3] "Before voting +1 [P]PMC members are required to download
the signed source code package, compile it as provided, and test
the resulting executable on their own platform, along with also
verifying that the package meets the requirements of the ASF policy
on releases."
You can achieve the above by following [4].
[ ] +1 accept (indicate what you validated - e.g. performed the non-RM
items in [4])
[ ] -1 reject (explanation required)
[1] https://repository.apache.org/content/repositories/orgapacheiotdb-1002
[2] https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.8.0/rc2
[3] https://www.apache.org/dev/release.html#approving-a-release
[4]
https://cwiki.apache.org/confluence/display/IOTDB/Validating+a+staged+Release
