Hi Sorry I’m -1 (binding) on this release as there a large number of jars in the source release.
I checked: - signature and hashes fine - incubating in name - DISCLAIMER exists - LICENSE could do with some improvements (see below) - all source file have ASF headers - unexpected compiled code in the source release (lots of jars) - can compile from source BTW it's always a good idea to run rat manually on the artefacts as it would catch issues like this. You may want to consider using the new DISCLAIMER-WIP [1] While OK, this text in LICENSE would be more descriptive: "The following class is modified from Maven Wrapper ./.mvn/wrapper/MavenWrapperDownloader.java” It should mentions the license it is under, the original copyright owner and ideally the version it came from. The file [2] is missing it's header, the original 3rd party header should be retained. Licenses can change over time so it always best to include that information. Some other minor issues that are not release blockers: - NOTICE-binary has "Copyright 2008-2018 The Apache Software Foundation” this should be 2018-2019. - NOTICE contains "Copyright 2019 and onwards” this is not correct as copyright has an expire date. Please replace with "Copyright 2019” - NOTICE contains "Copyright 2008-2019” for Apache Hive. are these years correct? I was able to sat up teh server but the client failed with this error: Error: Could not find or load main class org.apache.iotdb.cli.client.Client May just be my environment or my configuration but you may want to double check that works. Thanks, Justin 1. https://incubator.apache.org/policy/incubation.html#disclaimers 2. ./.mvn/wrapper/MavenWrapperDownloader.java
