Hi Xiangdong, I think it's quite import of the PPMC to run some tests or sample code on the release kit to make sure the kit is in good shape. It can give the IPMC some confidence when them send out their vote.
Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Aug 7, 2019 at 9:34 PM Xiangdong Huang <[email protected]> wrote: > > Hi, > > +1 PPMC vote > > I checked: > > - Build source bundle (mvn clean package) > - Checked the zip file in distribution/target, server/target, > client/target, grafana/target. All generated bin files work well. > - checked bin.zip file. > > > Minor issue: > > - do we need to remove LICENSE-binary and NOTICE-binary files from the > source.zip file? > > - I think Zhu's PR #332 should be involved in this release, otherwise users > can not find correct generated files according to README.md (I have not > reviewed all the contents of the PR) > > > One minor thing here: Hive in NOTICE is stated as 2008 - 2018... should > it be 2019 here? > > - I think 2008-2018 is correct because Hive project still uses that (see > https://github.com/apache/hive/blob/master/NOTICE ) ... maybe we should > wait for Hive updating that > > Best, > > ----------------------------------- > Xiangdong Huang > School of Software, Tsinghua University > > 黄向东 > 清华大学 软件学院 > > > Julian Feinauer <[email protected]> 于2019年8月7日周三 下午5:31写道： > > > Hi, > > > > my vote is > > +1 (non-binding) PPMC Vote > > but also > > +1 (binding) IPMC Vote > > (as I think the best practice is nowadays to also report IPMC Votes that > > where cast during PPMC Vote). > > > > I checked: > > > > - Downloaded staged artefacts > > - Validated Hases and Signatures > > - Build source bundle (mvn clean verify) > > - Verified existence of README; RELEASE_NOTES, LICENSE and NOTICES > > - [RM] Verified RELEADE_NOTES and README are the same as staged ones > > - checked the contents of LICENSE, NOTICE, README, RELEASE_NOTES > > - source bundle contains NO jars > > - Checked no snapshot references > > - UNPACKed the binary artefact and check the contents of LICENSE-binary > > and NOTICE-binary > > - [Not necessary] Started Server, started Client, Client connects > > sucessfully > > > > One minor issue found: > > One minor thing here: Hive in NOTICE is stated as 2008 - 2018... should it > > be 2019 here? > > > > Julian > > > > Am 06.08.19, 16:56 schrieb "Julian Feinauer" < > > [email protected]>: > > > > Hi all, > > > > thanks to cdutz for finding some major issues in RC2 and fixing them > > we are able to already provide RC3 now. > > > > Important: All PMCs please note that you have to CHECK the release > > artifacts [1] (see below) before being allowed to vote “+1”, see [3,4]. > > > > Apache IoTDB (Incubating) 0.8.0 has been staged under [1] and it’s > > time to vote > > on accepting it for release. All Maven artifacts are available under > > [2]. > > If approved we will seek final release approval from the IPMC. > > Voting will be open for 72hr. > > > > A minimum of 3 binding +1 votes and more binding +1 than binding -1 > > are required to pass. > > > > Release tag: release/0.8.0 > > Hash for the release tag: 2f4da03b05d1c063eaaca622c68de86abe35de22 > > > > Per [3] "Before voting +1 [P]PMC members are required to download > > the signed source code package, compile it as provided, and test > > the resulting executable on their own platform, along with also > > verifying that the package meets the requirements of the ASF policy > > on releases." > > > > You can achieve the above by following [4]. > > > > [ ] +1 accept (indicate what you validated - e.g. performed the > > non-RM items in [4]) > > [ ] -1 reject (explanation required) > > > > [1] https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.8.0/rc3 > > [2] > > https://repository.apache.org/content/repositories/orgapacheiotdb-1003 > > [3] https://www.apache.org/dev/release.html#approving-a-release > > [4] > > https://cwiki.apache.org/confluence/display/IOTDB/Validating+a+staged+Release > > > > > > > >
