Hi, +1 (binding)
I checked: - Build server and client (mvn clean package -pl server -am -Dmaven.test.skip=true, mvn clean package -pl client -am -Dmaven.test.skip=true) - All tests are passed on my laptop: macOS-10.14.5, jdk-1.8.0_112 - The zip file in server/target, client/target are good. - The bin.zip works well. The statements I used to test the binaries are: SET STORAGE GROUP TO root.turbine; CREATE TIMESERIES root.turbine.d1.s0 WITH DATATYPE=FLOAT, ENCODING=RLE; insert into root.turbine.d1(timestamp,s0) values(1,24.5); insert into root.turbine.d1(timestamp,s0) values(2,25.3); insert into root.turbine.d1(timestamp,s0) values(3,25.8); insert into root.turbine.d1(timestamp,s0) values(4,1000); insert into root.turbine.d1(timestamp,s0) values(5,1000); insert into root.turbine.d1(timestamp,s0) values(6,1000); insert into root.turbine.d1(timestamp,s0) values(7,25.9); insert into root.turbine.d1(timestamp,s0) values(8,25.8); select s0 from root.turbine.d1; delete from root.turbine.d1.s0 where time < 5; select s0 from root.turbine.d1; Minor issues: - When I run the tests, there are some compilation errors because of lack of generated sources codes, so I add a note in the readme and submit a PR [1] to rel/0.8. [1] https://github.com/apache/incubator-iotdb/pull/335 Best, -- Jialin Qiao School of Software, Tsinghua University 乔嘉林 清华大学 软件学院 > -----原始邮件----- > 发件人: "Christofer Dutz" <[email protected]> > 发送时间: 2019-08-10 18:06:36 (星期六) > 收件人: "[email protected]" <[email protected]> > 抄送: > 主题: Re: [VOTE] Apache IoTDB (Incubating) 0.8.0 RC3 > > +1 (binding) Chris > > Details of what I checked: > > Source-Release > - Signatures: OK > - Hashes: OK > - LICENSE, NOTICE, README, RELEASE_NOTES exist: OK > - README refers to wrong paths after the latest changes in the build > (client/target/iotdb-client-0.8.0 instead of client/cli ... same for server) > - RAT: OK > - The .checkstyle file doesn't have an Apache Header (minor issue) > - There seem to be some log files included in the source-bundle > (client/logs/* and tsfile/logs/*) they don't have Apache headers, but I think > this is just a minor thing (In general the source-release shouldn't contain > log files) > - The only binaries found are pictures > - Building: > - server as in the readme (mvn clean package -pl server -am > -Dmaven.test.skip=true): OK > - client as in the readme (mvn clean package -pl client -am > -Dmaven.test.skip=true): OK > - full build with all tests (mvn clean verify): OK > - Running Server: OK > - Running Client: OK > - No reference of SNAPSHOT versions: OK > - Only the Hadoop pom and the Dockerfile still reference SNAPSHOT > versions (minor) > > Binary distribution: > - Signatures: OK > - Hashes: OK > - Running Server: OK > - Running Client: OK > > > > Am 06.08.19, 16:56 schrieb "Julian Feinauer" <[email protected]>: > > Hi all, > > thanks to cdutz for finding some major issues in RC2 and fixing them we > are able to already provide RC3 now. > > Important: All PMCs please note that you have to CHECK the release > artifacts [1] (see below) before being allowed to vote “+1”, see [3,4]. > > Apache IoTDB (Incubating) 0.8.0 has been staged under [1] and it’s time > to vote > on accepting it for release. All Maven artifacts are available under [2]. > If approved we will seek final release approval from the IPMC. > Voting will be open for 72hr. > > A minimum of 3 binding +1 votes and more binding +1 than binding -1 > are required to pass. > > Release tag: release/0.8.0 > Hash for the release tag: 2f4da03b05d1c063eaaca622c68de86abe35de22 > > Per [3] "Before voting +1 [P]PMC members are required to download > the signed source code package, compile it as provided, and test > the resulting executable on their own platform, along with also > verifying that the package meets the requirements of the ASF policy > on releases." > > You can achieve the above by following [4]. > > [ ] +1 accept (indicate what you validated - e.g. performed the non-RM > items in [4]) > [ ] -1 reject (explanation required) > > [1] https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.8.0/rc3 > [2] https://repository.apache.org/content/repositories/orgapacheiotdb-1003 > [3] https://www.apache.org/dev/release.html#approving-a-release > [4] > https://cwiki.apache.org/confluence/display/IOTDB/Validating+a+staged+Release > > >
