Yeah ... I wanted to say, the .gitignore helps preventing to accidentally check it in, but it doesn't automatically exclude it from the source assembly.
Guess I never before used the maven wrapper for building a release (Always have maven installed) ... But thinking about it ... this file actually should never have been there in the first place ... The release plugin does the preparing of a release (change the version to a non-SNAPSHOT version) and then tags this version and then changes to the next development version and checks both in. The actual release is then built during the release:perform step by checking out this tag from git into an empty "target/checkout" directory and spawning a new maven build in that directory (without the maven wrapper). So this jar shouldn't have been there, as it is only downloaded when running maven manually using the mvnw script, which the release:perform goal of the release plugin doesn't do. I am not quite sure, but I guess when preparing the release the steps haven't been executed as written in the RM guide. Using it, the file shouldn't have been there and there shouldn't be the need to adjust the assembly descriptor to exclude that file. Chris Am 12.10.19, 05:56 schrieb "Willem Jiang" <[email protected]>: en, Justin, you are right. We need to update the distribution assembly file at the same time. I just update the JIRA issue about this. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Sat, Oct 12, 2019 at 10:22 AM Justin Mclean <[email protected]> wrote: > > HI, > > > For the jar in the source release, we could address it by adding below > > line into .gitignore file. > > #skip the maven-wrapper.jar > > .mvn/wrapper/maven-wrapper.jar > > How would that fix it? The release needs to be be made on on the RM machine not from guthub and GitHub doesn’t currently have that jar. [1] > > Thanks, > Justin > > 1. https://github.com/apache/incubator-iotdb/tree/master/.mvn/wrapper
