Hi, I submitted a PR [1] for it.
[1] https://github.com/apache/incubator-iotdb/pull/447 Thanks, -- Jialin Qiao School of Software, Tsinghua University 乔嘉林 清华大学 软件学院 > -----原始邮件----- > 发件人: "Willem Jiang" <[email protected]> > 发送时间: 2019-10-12 09:02:00 (星期六) > 收件人: [email protected] > 抄送: > 主题: Re: [VOTE] Apache IoTDB 0.8.1 (incubating) RC2 release > > For the jar in the source release, we could address it by adding below > line into .gitignore file. > #skip the maven-wrapper.jar > .mvn/wrapper/maven-wrapper.jar > > I just create a JIRA[1] for it. > [1]https://issues.apache.org/jira/browse/IOTDB-250 > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Sat, Oct 12, 2019 at 5:21 AM Justin Mclean <[email protected]> > wrote: > > > > Hi, > > > > Sorry but it’s -1 (binding) as there is a compiled binary in the source > > release [2] > > > > If you had used the the work in progress disclaimer that would of been > > allowed. > > > > I checked: > > - incubating in name > > - signature and hashes fine > > - disclaimer exists > > - LICENSE is fine ( although it would be good to mention what license the > > man wrapper is under) > > - NOTICE incorrectly has "Copyright 2019 and onwards” in it > > - the is a jar in the source release this is not allowed [2] > > - all source files have ASF headers > > > > It’s a good idea to use a checklist like this [1] to check the release. If > > so you had done so you should have picked up the binary in the source > > release and the minor NOTICE issues. > > > > Looking at the binary the licensing is not correct as you have multiple > > versions of different licenses but only include the text of one of them. > > For instance you list two MIT licensed pieces of software but you only have > > one MIT license, note that MIT licenses differ and have different copyright > > lines. The binary LICENSE file is also missing a number of licenses: > > airline > > guava > > hawtjni > > jansi > > tongfei progressbar > > javax inject > > > > Thanks, > > Justin > > > > 1. > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > 2. .mvn/wrapper/maven-wrapper.jar
