Hi, my vote is +1 (PPMC binding).
I followed [1] and checked:
1. download staged artifacts. Check their signature and hashes.
✔ [RM] verify the reported signature is for an "apache.org" address ("gpg: Good
signature from ...")
✔ [RM] verify the reported hashes
2. extract src bundle
✔ verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files in the
extracted source bundle
✔ [RM] verify the staged source README, RELEASE_NOTE files correspond to those
in the extracted source bundle
3. staged src bundle items: content, can compile & test
✔ check the contents of LICENSE, NOTICE, README, RELEASE_NOTES
✔ UNPACK the binary artefact and check the contents of LICENSE-binary and
NOTICE-binary
✔ build from directions in README with an empty maven local repo: mvn clean
package -DskipTests -Dmaven.repo.local=../.m2
✔ [RM] review target/rat.txt (though the build should fail if RAT constraints
aren't met)
- mvn clean apache-rat:check
- Find and files containing binary content with this command: find .
-type f -name 'rat.txt' -exec grep -l " B " {} \;
- Then review for B (binary) content in those files:
grep " B " ./grafana/target/rat.txt
grep " B " ./server/target/rat.txt
I find:
B
/home/ruilei/tools/downloaded-iotdb-0.9.0rc4/0.9.0/rc4/apache-iotdb-0.9.0-incubating/grafana/img/add_data_source.png
B
/home/ruilei/tools/downloaded-iotdb-0.9.0rc4/0.9.0/rc4/apache-iotdb-0.9.0-incubating/grafana/img/edit_data_source.png
B
/home/ruilei/tools/downloaded-iotdb-0.9.0rc4/0.9.0/rc4/apache-iotdb-0.9.0-incubating/grafana/img/add_graph.png
B
/home/ruilei/tools/downloaded-iotdb-0.9.0rc4/0.9.0/rc4/apache-iotdb-0.9.0-incubating/server/src/main/resources/iotdb/ui/static/iotdb-logo.png
✔ Search for SNAPSHOT references: find . -type f -name 'pom.xml' -exec grep -l
"SNAPSHOT" {} \;
✔ ./mvnw.sh install
✔ ./mvnw.sh site:site
Best,
Lei Rui
[1]https://cwiki.apache.org/confluence/display/IOTDB/Validating+a+staged+Release
On 11/23/2019 18:56，Jialin Qiao<qj...@mails.tsinghua.edu.cn> wrote：
Hi all,
Now I open a new ticket for Apache IoTDB (incubating) 0.9.0 RC5, which fixs
some issues comparing with RC4. You can find the details at the end of this
email.
Apache IoTDB (incubating) 0.9.0 is a major version with many exciting features.
You can get the release notes in [5].
Apache IoTDB (Incubating) 0.9.0 has been staged under [2] and it’s time to
vote on accepting it for release. All Maven artifacts are available under [1].
If approved we will seek final release approval from the IPMC.
Voting will be open for 72hr.
A minimum of 3 binding +1 votes and more binding +1 than binding -1 are
required to pass.
Release tag: release/0.9.0
Hash for the release tag: 257df94d57c29c628b1ab0d6a2fdd20ba7df9ca4
Per [3] "Before voting +1 PMC/PPMC members are required to download the
signed source code package, compile it as provided, and test the resulting
executable on their own platform, along with also verifying that the package
meets the requirements of the ASF policy on releases."
Difference with RC4:
- Fix windows start problem
- Fix deadlock between merge and query
You can achieve the above by following [4].
[ ] +1 accept (indicate what you validated - e.g. performed the non-RM items
in [4])
[ ] -1 reject (explanation required)
[1] https://repository.apache.org/content/repositories/orgapacheiotdb-1018
[2] https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.9.0/rc5
[3] https://www.apache.org/dev/release.html#approving-a-release
[4]
https://cwiki.apache.org/confluence/display/IOTDB/Validating+a+staged+Release
[5]
https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.9.0/rc5/RELEASE_NOTES.md
Thanks,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
