Hi @sunjincheng121 , 

Sorry for somehow ignoring the "latest news" part… 
And many thanks for the suggestions! I will notice the PR and commit format in 
the future : )


Best,
-----------------------------------
Zesong Sun
School of Software, Tsinghua University

孙泽嵩
清华大学 软件学院

> 2019年12月23日 22:11,jincheng sun <[email protected]> 写道:
> 
> Thanks for your conformation Jack,Xiangdong!
> 
> Thanks for the PR Zesong!
> 
> I manually established the JIRA(IOTDB-384) and PR(54) links, and left the
> following 3 suggestions in the PR:
> 
>    -  It's better to contain JIRA. number in the PR title. such as:
> [IOTDB-384] ix main feature text style in homepage. Then the reviewer can
> know the JIRA of the PR easily.
>    - The commit message should contain the JIRA. number such as :
> [IOTDB-384] ix main feature text style in homepage.Then the JIRA and the PR
> can make the relation automatically
>    -  It's better to fix the problem of "Latest News " in the PR(54).
> 
> What do you think ?
> Best,
> Jincheng
> 
> 
> 孙泽嵩 <[email protected]> 于2019年12月23日周一 下午8:51写道:
> 
>> Sure, if you all think it will be better : ) Here is PR [1] and result
>> 
>> [1] https://github.com/apache/incubator-iotdb-website/pull/54 <
>> https://github.com/apache/incubator-iotdb-website/pull/54>
>> 
>> 
>> 
>> Best,
>> -----------------------------------
>> Zesong Sun
>> School of Software, Tsinghua University
>> 
>> 孙泽嵩
>> 清华大学 软件学院
>> 
>>> 2019年12月23日 20:40,Xiangdong Huang <[email protected]> 写道:
>>> 
>>> Hi @Zesong, do you have time to fix the style?
>>> 
>>> Best,
>>> -----------------------------------
>>> Xiangdong Huang
>>> School of Software, Tsinghua University
>>> 
>>> 黄向东
>>> 清华大学 软件学院
>>> 
>>> 
>>> Jack Tsai <[email protected]> 于2019年12月23日周一 下午5:30写道:
>>> 
>>>> Hi,
>>>> 
>>>> Agree. Looks better while applying “align left”.
>>>> 
>>>> Best regards,
>>>> Jack Tsai
>>>> 
>>>> 取得 iOS 版 Outlook<https://aka.ms/o0ukef>
>>>> ________________________________
>>>> 寄件者: jincheng sun <[email protected]>
>>>> 寄件日期: Monday, December 23, 2019 9:18:17 AM
>>>> 收件者: [email protected] <[email protected]>
>>>> 主旨: [DISCUSS] Using align `left` take over `justify` text-align style in
>>>> IoTDb website
>>>> 
>>>> Hi folks,
>>>> 
>>>> When I reading home of the IoTDB website [1], I feel that the display
>> style
>>>> of "Main Features" is very uncomfortable, and the text spacing is
>>>> different, just like a bug, but it is actually a problem of the display
>>>> style(text align: justify).
>>>> 
>>>> I propose using align `left` take over `justify` text-align style in
>> IoTDB
>>>> website.
>>>> 
>>>> The modified display effect comparison can be viewed in [2] or [3]
>>>> 
>>>> BTW. The area of "Latest News " has the same problem, i.e., the style of
>>>> "list-unstyled" should be replace by other style.
>>>> 
>>>> What do you think? Welcome any feedback :)
>>>> 
>>>> Best,
>>>> Jincheng
>>>> 
>>>> [1] https://iotdb.apache.org
>>>> [2]
>>>> 
>>>> 
>> https://issues.apache.org/jira/secure/attachment/12989376/image-2019-12-23-16-49-25-077.png
>>>> [3] https://issues.apache.org/jira/browse/IOTDB-384
>>>> 
>> 
>> 

Reply via email to