Hi Wei, > I think you should update the master branch again.
Yes, keep update with the latest code branch will make it easier to merge your PR, as the PR would not be blocked because of conflict. So, you'd better merge/rebase the master branch frequently. > I know the official codebase is at GitLab, but in the process, I would recommend you to use your GitHub fork. Anyway, you finally need to contribute your codes to Skywalking's official codebase back, (and we hope your work can be accepted :D). At that time, you need to submit a PR on github. We will only review the modified codes. Best, ----------------------------------- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Sheng Wu <[email protected]> 于2021年7月21日周三 下午11:06写道： > I think you should update the master branch again. We have improved the > performance, which includes a little API change on the storage option, but > InfluxDB is safe for now. > I know the official codebase is at GitLab, but in the process, I would > recommend you to use your GitHub fork. > It would be easier to review, and you could adopt our e2e test framework, > which covers InfluxDB cases in the GitHub Action processes. > > If you need more helps, welcome to talk with your mentor, and I could join > your meeting to support if you need. > > Sheng Wu 吴晟 > Twitter, wusheng1108 > > > 刘威 <[email protected]> 于2021年7月21日周三 下午7:19写道： > > > Hi, I'm a participant in Summer 2021 of Open Source Promotion Plan. My > > name is Liu Wei, I come from Northwestern Polytechnical University(NWPU), > > Xi'an, China.I'm working on creating an IOTDB-Skywalking Adapter. Hope to > > join community to get more help. > > > > > > I follow the guide Extend storage | Apache SkyWalking to build my > > code skeleton and take the Influxdb storage solution as a reference. My > > Mentor Xiangdong Huang discussed this project with me and gave me > some > > suggestions. What's more, I have pushed my code to Summer2021 / > > 210070771 · GitLab (summer-ospp.ac.cn) in iotdb-adapter branch. > > > > > > Now I have a question: > > 1. Which skywalking version should I base? I pulled skywalking master in > > June 12th. Maybe it's not stable enough to develop a new storage > > solution. (My IoTDB version is 0.12.2.) > > 2. Do you have other helpful information or resources? Please give me > some > > suggestions. Thanks you in advance. > > > > > > Hope to get reply. >
