+1 for Plan A.
Thanks. Guanfei Guo From: ycy wi Date: 2023-02-06 15:13 To: dev Subject: Re: About naming of VerticallyConcatOperator +1 for Plan A. "Vertically" and "Horizontally" are adverbs. I think it's easier to understand from a straightforward perspective. Xiangwei Wei <[email protected]> 于2023年2月6日周一 14:35写道： > VerticallyConcatOperator is used to horizontally concatenate TsBlocks with > the same timestamp column. For example, > TsBlock A is: > | Time | ColumnA | > | 1 | 1.0 | > TsBlock B is: > | Time | ColumnB | > | 1 | 2.0 | > After the VerticallyConcatOperator, the result will be: > | Time | ColumnA | ColumnB | > | 1 | 1.0 | 2.0 | > > Literally, I think it's a horizontal concatenation. So I suggest rename it > as HorizontallyConcatOperator. > > However, I asked the author about the reason for this name. He said, "From > the view of a table, adding columns means vertical changes." > > What's your opinion? > > +1 for Plan A: Rename it as HorizontallyConcatOperator. > +1 for Plan B: Keep current name VerticallyConcatOperator. > > -- > Best, > Xiangwei Wei >
