Hi, all. I got 5 +1 for planA: Rename it as HorizontallyConcatOperator, including the origin author. So I will rename it. Thank you.
The pr is [1]. [1] https://github.com/apache/iotdb/pull/9007 Yuan Tian <[email protected]> 于2023年2月7日周二 10:37写道： > Fine, I change my mind, +1 for planA > > Best, > --------------------- > Yuan Tian > > On Mon, Feb 6, 2023 at 2:35 PM Xiangwei Wei <[email protected]> wrote: > > > > VerticallyConcatOperator is used to horizontally concatenate TsBlocks > with > > the same timestamp column. For example, > > TsBlock A is: > > | Time | ColumnA | > > | 1 | 1.0 | > > TsBlock B is: > > | Time | ColumnB | > > | 1 | 2.0 | > > After the VerticallyConcatOperator, the result will be: > > | Time | ColumnA | ColumnB | > > | 1 | 1.0 | 2.0 | > > > > Literally, I think it's a horizontal concatenation. So I suggest rename > it > > as HorizontallyConcatOperator. > > > > However, I asked the author about the reason for this name. He said, > "From > > the view of a table, adding columns means vertical changes." > > > > What's your opinion? > > > > +1 for Plan A: Rename it as HorizontallyConcatOperator. > > +1 for Plan B: Keep current name VerticallyConcatOperator. > > > > -- > > Best, > > Xiangwei Wei > -- Best, Xiangwei Wei
