Hi, chris

I personally think spoltess makes sense here, otherwise it's a pain to review 
pr and see a lot of style changes.

As for making a pre-commit-hook locally, that seems like a pretty smart 
solution.

As for forcing spotless::apply at build time, is it possible to make all code 
that doesn't meet spotless check pass? If so, it doesn't feel good. If we have 
to, maybe we can get a robot to help people go to spotless apply?

Best
----------------
Xinyu Tan

On 2024/08/19 12:07:02 Christofer Dutz wrote:
> Hi all,
> 
> admittedly our usage of spotless is really starting to annoy me … I can’t say 
> how many extra runs of the build I had to do in the last year just because of 
> this.
> As we’re letting the build fail anyway if the issues are not corrected, how 
> about instead of running “check” we switch to run “apply”?
> 
> I currently even setup a pre-commit-hook that runs spotless:check before 
> committing, as I wanted to avoid unnecessary roundtrips.
> 
> I personally would even opt for not using spotless, but that’s another type 
> of discussion, but the current way just keeps on pulling me out of the flow 
> way too often.
> 
> Chris
> 

Reply via email to