Re: Re: General Workflow?

[Yuan Tian]

Hi hongzhi,

I think that's a good idea, I'll prepare such a list  this weekend.

Best regards,
-------------------
Yuan Tian


On Thu, Nov 5, 2026 at 7:39 PM 高宏志 via dev <dev@iotdb.apache.org> wrote:

> Hi all,
>
> How about combining a manually maintained module owner list with
> history-based reviewer recommendations?
>
>
> Maintain module paths and their responsible committers in
> .github/CODEOWNERS.
>
>
>
> When a PR is ready for review, automatically request reviews from the
> relevant module owners and contributors familiar with the changed code,
> based on recent contributions and review history.
>
>
>
> Once CI passes and technical review is complete, notify the responsible
> committers for final approval and merging.
>
>
> Contributors could participate in technical reviews, while final approval
> and merging would remain with committers.
>
> Would this be a reasonable starting point?
>
> Best,
> Hongzhi Gao
>
>
>
>
> 高宏志
> 761417...@qq.com
>
>
>
>
>
>
>
>          原始邮件
>
>
> 发件人：Xiangdong Huang <saint...@gmail.com&gt;
> 发件时间：2026年11月5日 16:54
> 收件人：dev <dev@iotdb.apache.org&gt;
> 主题：Re: Re: General Workflow?
>
>
>
>
>  
> well,&nbsp;this&nbsp;is&nbsp;an&nbsp;interesting&nbsp;issue,&nbsp;how&nbsp;to&nbsp;let&nbsp;the&nbsp;community&nbsp;know&nbsp;who
> should&nbsp;be&nbsp;considered&nbsp;as&nbsp;reviewers..
>
>
> how&nbsp;about&nbsp;implement&nbsp;a&nbsp;github&nbsp;action&nbsp;to&nbsp;auto-suggesting&nbsp;PR&nbsp;reviewers
> based&nbsp;on&nbsp;module&nbsp;history
>
> (Recently,&nbsp;I&nbsp;have&nbsp;been&nbsp;conducting&nbsp;academic&nbsp;research&nbsp;on&nbsp;the&nbsp;development
> of&nbsp;open-source&nbsp;communities)
>
> -----------------------------------
> Xiangdong&nbsp;Huang
> School&nbsp;of&nbsp;Software,&nbsp;Tsinghua&nbsp;University
>
> &nbsp;黄向东
> 清华大学&nbsp;软件学院
>
> Yuan&nbsp;Tian&nbsp;<jackietie...@gmail.com
> &gt;&nbsp;于2026年11月5日周四&nbsp;07:41写道：
>
> &gt;
> &gt;&nbsp;Hi&nbsp;Chris,
> &gt;
>
> &gt;&nbsp;We&nbsp;don’t&nbsp;currently&nbsp;have&nbsp;a&nbsp;formal&nbsp;rule&nbsp;for&nbsp;this.&nbsp;In&nbsp;practice,&nbsp;the&nbsp;person
>
> &gt;&nbsp;most&nbsp;familiar&nbsp;with&nbsp;the&nbsp;relevant&nbsp;module,&nbsp;who&nbsp;is&nbsp;at&nbsp;least&nbsp;a&nbsp;committer,
>
> &gt;&nbsp;usually&nbsp;reviews&nbsp;and&nbsp;approves&nbsp;the&nbsp;PR,&nbsp;then&nbsp;merges&nbsp;it&nbsp;as&nbsp;well.
> &gt;
>
> &gt;&nbsp;In&nbsp;the&nbsp;example&nbsp;you&nbsp;mentioned,&nbsp;Caideyipi&nbsp;is&nbsp;the&nbsp;person&nbsp;most&nbsp;familiar&nbsp;with
>
> &gt;&nbsp;the&nbsp;Pipe&nbsp;module,&nbsp;so&nbsp;he&nbsp;would&nbsp;normally&nbsp;merge&nbsp;the&nbsp;PR&nbsp;after&nbsp;approving&nbsp;it.&nbsp;If
>
> &gt;&nbsp;the&nbsp;PR&nbsp;author&nbsp;is&nbsp;themselves&nbsp;the&nbsp;maintainer&nbsp;of&nbsp;the&nbsp;module,&nbsp;they&nbsp;can&nbsp;merge
> &gt;&nbsp;their&nbsp;own&nbsp;PR.
> &gt;
> &gt;&nbsp;Best,
> &gt;&nbsp;Yuan
> &gt;
>
> &gt;&nbsp;On&nbsp;Wed,&nbsp;Nov&nbsp;4,&nbsp;2026&nbsp;at&nbsp;3:35 
> PM&nbsp;Christofer&nbsp;Dutz&nbsp;via&nbsp;dev&nbsp;<
> dev@iotdb.apache.org&gt;
> &gt;&nbsp;wrote:
> &gt;
> &gt;&nbsp;&gt;&nbsp;Hi,
> &gt;&nbsp;&gt;
>
> &gt;&nbsp;&gt;&nbsp;well&nbsp;...&nbsp;I&nbsp;guess&nbsp;what&nbsp;I'm&nbsp;more&nbsp;referring&nbsp;to&nbsp;...&nbsp;do&nbsp;I&nbsp;merge&nbsp;PRs&nbsp;myself,&nbsp;but
> &gt;&nbsp;&gt;&nbsp;only&nbsp;if&nbsp;they&nbsp;got&nbsp;approval?
>
> &gt;&nbsp;&gt;&nbsp;If&nbsp;only&nbsp;if&nbsp;they&nbsp;got&nbsp;approval:&nbsp;Who's&nbsp;approval&nbsp;should&nbsp;I&nbsp;base&nbsp;this&nbsp;on.&nbsp;Is&nbsp;it
> &gt;&nbsp;&gt;&nbsp;any&nbsp;committers&nbsp;approval?
>
> &gt;&nbsp;&gt;&nbsp;Is&nbsp;it&nbsp;a&nbsp;PMC&nbsp;member's&nbsp;approval?&nbsp;Is&nbsp;it&nbsp;some&nbsp;other&nbsp;team&nbsp;member's&nbsp;approval?
> &gt;&nbsp;&gt;
> &gt;&nbsp;&gt;&nbsp;Chris
> &gt;&nbsp;&gt;
> &gt;&nbsp;&gt;
> &gt;&nbsp;&gt;
> &gt;&nbsp;&gt;&nbsp;Yuan&nbsp;Tian&nbsp;<jackietie...@gmail.com
> &gt;&nbsp;schrieb&nbsp;am&nbsp;Mittwoch,&nbsp;4.&nbsp;November&nbsp;2026
> &gt;&nbsp;&gt;&nbsp;um&nbsp;00:47:
> &gt;&nbsp;&gt;
> &gt;&nbsp;&gt;&nbsp;&gt;&nbsp;Hi&nbsp;Chris,
> &gt;&nbsp;&gt;&nbsp;&gt;
>
> &gt;&nbsp;&gt;&nbsp;&gt;&nbsp;We&nbsp;need&nbsp;someone&nbsp;who&nbsp;is&nbsp;familiar&nbsp;with&nbsp;that&nbsp;module&nbsp;to&nbsp;give&nbsp;an&nbsp;approval&nbsp;on
>
> &gt;&nbsp;&gt;&nbsp;&gt;&nbsp;that,&nbsp;and&nbsp;sorry&nbsp;for&nbsp;the&nbsp;late&nbsp;reply,&nbsp;I'm&nbsp;a&nbsp;little&nbsp;busy&nbsp;this&nbsp;week,&nbsp;I'll
>
> &gt;&nbsp;&gt;&nbsp;&gt;&nbsp;review&nbsp;some&nbsp;prs&nbsp;related&nbsp;to&nbsp;the&nbsp;query&nbsp;module&nbsp;when&nbsp;I'm&nbsp;free.
> &gt;&nbsp;&gt;&nbsp;&gt;
> &gt;&nbsp;&gt;&nbsp;&gt;
>
> &gt;&nbsp;&gt;&nbsp;&gt;&nbsp;On&nbsp;Tue,&nbsp;Nov&nbsp;3,&nbsp;2026&nbsp;at&nbsp;5:00
>  PM&nbsp;Christofer&nbsp;Dutz&nbsp;via&nbsp;dev&nbsp;<
> &gt;&nbsp;&gt;&nbsp;dev@iotdb.apache.org&gt;
> &gt;&nbsp;&gt;&nbsp;&gt;&nbsp;wrote:
> &gt;&nbsp;&gt;&nbsp;&gt;
> &gt;&nbsp;&gt;&nbsp;&gt;&nbsp;&gt;&nbsp;Hi&nbsp;all,
> &gt;&nbsp;&gt;&nbsp;&gt;&nbsp;&gt;
>
> &gt;&nbsp;&gt;&nbsp;&gt;&nbsp;&gt;&nbsp;I&nbsp;just&nbsp;need&nbsp;a&nbsp;short&nbsp;refresher&nbsp;on&nbsp;the&nbsp;general&nbsp;workflow&nbsp;here&nbsp;...&nbsp;I'm
>
> &gt;&nbsp;&gt;&nbsp;&gt;&nbsp;&gt;&nbsp;currently&nbsp;submitting&nbsp;several&nbsp;small&nbsp;PRs.
>
> &gt;&nbsp;&gt;&nbsp;&gt;&nbsp;&gt;&nbsp;I&nbsp;don't&nbsp;merge&nbsp;them&nbsp;without&nbsp;someone&nbsp;else&nbsp;approving&nbsp;them.
>
> &gt;&nbsp;&gt;&nbsp;&gt;&nbsp;&gt;&nbsp;If&nbsp;someone&nbsp;approves&nbsp;them,&nbsp;then&nbsp;I&nbsp;do&nbsp;the&nbsp;merging?&nbsp;Or&nbsp;does&nbsp;someone&nbsp;else
> &gt;&nbsp;&gt;&nbsp;do
> &gt;&nbsp;&gt;&nbsp;&gt;&nbsp;&gt;&nbsp;that?
> &gt;&nbsp;&gt;&nbsp;&gt;&nbsp;&gt;
> &gt;&nbsp;&gt;&nbsp;&gt;&nbsp;&gt;&nbsp;Chris
> &gt;&nbsp;&gt;&nbsp;&gt;
> &gt;&nbsp;&gt;