Hi Chris, We don’t currently have a formal rule for this. In practice, the person most familiar with the relevant module, who is at least a committer, usually reviews and approves the PR, then merges it as well.
In the example you mentioned, Caideyipi is the person most familiar with the Pipe module, so he would normally merge the PR after approving it. If the PR author is themselves the maintainer of the module, they can merge their own PR. Best, Yuan On Wed, Nov 4, 2026 at 3:35 PM Christofer Dutz via dev <[email protected]> wrote: > Hi, > > well ... I guess what I'm more referring to ... do I merge PRs myself, but > only if they got approval? > If only if they got approval: Who's approval should I base this on. Is it > any committers approval? > Is it a PMC member's approval? Is it some other team member's approval? > > Chris > > > > Yuan Tian <[email protected]> schrieb am Mittwoch, 4. November 2026 > um 00:47: > > > Hi Chris, > > > > We need someone who is familiar with that module to give an approval on > > that, and sorry for the late reply, I'm a little busy this week, I'll > > review some prs related to the query module when I'm free. > > > > > > On Tue, Nov 3, 2026 at 5:00 PM Christofer Dutz via dev < > [email protected]> > > wrote: > > > > > Hi all, > > > > > > I just need a short refresher on the general workflow here ... I'm > > > currently submitting several small PRs. > > > I don't merge them without someone else approving them. > > > If someone approves them, then I do the merging? Or does someone else > do > > > that? > > > > > > Chris > > >
