That sounds good enough. Will work on maven build for my viewer. Regards Bhargav Golla
On 8 Oct 2013 12:00, "Dan Haywood" <[email protected]> wrote: > > cc'ing dev > > > > On 8 October 2013 07:16, Bhargav Golla <[email protected]> wrote: >> >> Hi Dimuthu >> >> When I was looking for solution to my maven problem, I tried building Android viewer. I see that you're hardcoding your android sdk location in pom.xml. I don't think this should be done that way. I am facing errors when I am building it on my machine. It says "Unresolveable build extension. Unknown packaging apk". Hardcoding the sdk location could be a reason probably? >> >> @Dan: From my previous GSoC experience, a user has to first install Android SDK and then proceed to build Android viewer and he has to install Phonegap Android jar into his local maven repo and then build my JS viewer to package it into android app. You can find here[1] how we packaged our PhotArk mobile app. Doesn't this impact your plan of letting user just use "mvn clean install" to package our viewers as well? > > > Yes, it does. Though I can see that there would likely be some prerequisites that a developer would need to install (such as the Android SDK etc). > > I think a reasonable compromise would be for us to put the building of these viewers into a separate profile that is not active by default... then the dev could go "mvn clean install -P androidviewer" etc. > > Cheers > Dan > >> >> [1] http://github.com/bhargavgolla/photark-mobile/blob/trunk/README.txt >> >> Regards >> >> Bhargav Golla >> >> On 8 Oct 2013 01:39, "Bhargav Golla" <[email protected]> wrote: >>> >>> Hi Dan >>> >>> Thanks for the wishes. We couldn't have made it through to this stage without your active support during the entire course of GSoC and not to forget Maurizio's and Jeroen's timely help whenever I went clueless. >>> >>> Regarding code transfer, I am still working on Maven build and haven't been able to make good progress. Would it be okay even if there's no maven build for now? >>> >>> Regards >>> >>> Bhargav Golla >>> Developer. Freelancer. >>> B.E (Hons.) Computer Science >>> BITS-Pilani >>> Github | LinkedIN | Website >>> >>> >>> On Mon, Oct 7, 2013 at 12:54 PM, Dan Haywood < [email protected]> wrote: >>>> >>>> Hi Dimuthu and Bhargav, >>>> >>>> First, just to say congratulations to you both on successfully completing GSOC this year; I hope you enjoyed doing the work and learnt some new stuff, with the added bonus of getting paid by Google! >>>> >>>> You might have seen that Google's open source blog contains posted a short piece [1] that the ASF provided about several of its GSOC projects. I contributed a couple of paragraphs about your projects, so your successful involvement on GSOC 2013 is now on public record! >>>> >>>> As I said in that post, I believe that you are both keen to continue developing your respective viewers. What I would therefore like to do is to copy over the code from your github repos (as a mega-patch in each case) into the Isis codebase... you have both lodged ICLAs with the ASF secretary so I don't think there's any further paperwork required. >>>> >>>> In order for you to continue developing the viewers it would mean, in the short-term, that you would need to raise tickets and provide patches. Later, though - once there's enough evidence to the community of ongoing involvement - I would put a vote forward for you to become committers so you can continue to develop them directly. >>>> >>>> Of course, with your projects as part of Isis codebase, there's the chance that others may want to take your work and develop it further; that's to be expected, of course. >>>> >>>> Let me know if you have any objections to the above, otherwise I'll copy the code over later this week/early next. >>>> >>>> Cheers >>>> Dan >>>> >>>> PS: I must also say thanks to Maurizio for co-mentoring Dimuthu and Bhargav; your in-depth technical expertise of Android/Javascript was invaluable! >>>> >>>> [1] http://google-opensource.blogspot.co.uk/2013/10/google-summer-of-code-veteran-orgs.html >>> >>> >
