On Mon, Dec 29, 2014 at 2:31 PM, Dan Haywood <d...@haywood-associates.co.uk> wrote:
> On 29 December 2014 at 13:18, Jeroen van der Wal <jer...@stromboli.it> > wrote: > > > Looks good to me too! Some comments: > > > > regexPatternReplacement: > > Is this the input placeholder? In that case I would choose to add a > > "placeholder" attribute on @PropertyLayout and @ParameterLayout [1] > > > > > No, it's to provide a user-friendly message in the validation message. > > eg: rather than say "the input didn't match '.+@.+' > > the message can say "the input isn't a valid email address > > > (This is Rob Matthew's original design for @RegEx. Looking at the current > implementation I think it's slightly broken, but I think it's worth > resurrecting/fixing). > > > > > > regexPatternFlags: > > this is obsolete if you add "(?i)" to the pattern. > > > > > True, but the flags parameter to compile covers more than this, see: > > > http://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html#compile(java.lang.String,%20int) > I would rather use the more portable regex modifier flags but that's a matter of taste I guess: http://www.regular-expressions.info/modifiers.html > Thx > Dan > > > > > Cheers, > > > > Jeroen > > > > > > [1] http://www.w3schools.com/tags/att_input_placeholder.asp > > > > On Mon, Dec 29, 2014 at 11:45 AM, Martin Grigorov <mgrigo...@apache.org> > > wrote: > > > > > Hi, > > > > > > Looks good to me! > > > > > > Martin Grigorov > > > Wicket Training and Consulting > > > https://twitter.com/mtgrigorov > > > > > > On Mon, Dec 29, 2014 at 12:36 PM, Dan Haywood < > > > d...@haywood-associates.co.uk> > > > wrote: > > > > > > > Hi folks, > > > > > > > > have done some further tidy up on the new annotations for domain > > > semantics, > > > > ie @DomainObject, @Property, @Collection, @Action and @Parameter. > > > > > > > > Nothing yet implemented in terms of facet factories, but think I have > > the > > > > annotations themselves pretty much finalized [1]. > > > > > > > > Would appreciate a review from anyone interested, save me reworking > > stuff > > > > > > > > Cheers > > > > Dan > > > > > > > > [1] https://issues.apache.org/jira/browse/ISIS-970 > > > > > > > > > >
