andi-huber commented on code in PR #1044:
URL: https://github.com/apache/isis/pull/1044#discussion_r938414730
##########
core/security/src/main/java/org/apache/isis/core/security/authorization/manager/AuthorizationManager.java:
##########
@@ -50,7 +50,6 @@ public class AuthorizationManager {
@Inject
public AuthorizationManager(
final List<Authorizor> authorizors,
- // TODO: elsewhere we inject an Optional<X>, should use the same
technique throughout...
@org.springframework.lang.Nullable final AuthorizorChooser
authorizorChooser) {
Review Comment:
TODO: actually use Optional<X> here ... as this is the more common idiom
within the framework, which does not depend on specific Spring annotations
(that are less robust regarding accidental refactoring sloppiness)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
